Skip to content

Translate hooks-custom#65

Merged
smikitky merged 3 commits into
masterfrom
tr/hooks-custom
Feb 14, 2019
Merged

Translate hooks-custom#65
smikitky merged 3 commits into
masterfrom
tr/hooks-custom

Conversation

@smikitky

@smikitky smikitky commented Feb 5, 2019

Copy link
Copy Markdown
Member

6/8 of Hooks articles

@smikitky smikitky requested review from koba04 and potato4d February 5, 2019 15:55
@tesseralis tesseralis mentioned this pull request Feb 6, 2019
90 tasks
@smikitky

smikitky commented Feb 7, 2019

Copy link
Copy Markdown
Member Author

#91 でフックに関わる差分がマージされます。翻訳を修正するまでマージはお待ちください。

@smikitky

smikitky commented Feb 7, 2019

Copy link
Copy Markdown
Member Author

修正しました

@smikitky

smikitky commented Feb 9, 2019

Copy link
Copy Markdown
Member Author

直ってないみたい…

@koba04 koba04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflictしてる以外は問題ないと思うのでApproveしておきます。

@potato4d potato4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうですー。
もしコンフリクト解消、マージ後に Lint が落ちてたら修正してもらって、そこからセルフマージで大丈夫です!

@smikitky smikitky merged commit ed05a3b into master Feb 14, 2019
@smikitky smikitky deleted the tr/hooks-custom branch February 14, 2019 09:19
@smikitky

Copy link
Copy Markdown
Member Author

ありがとうございました!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants